[libcxx-commits] [PATCH] D92571: [IR] Remove CastInst::isCastable since it is not used

Duncan P. N. Exon Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 3 12:01:50 PST 2020


dexonsmith accepted this revision.
dexonsmith added a comment.

LGTM too if you drop the libcxxabi change.

If there's an out-of-tree user that needs this we can revert again if it makes sense to (in which case, it'd be better to change `getCastOpcode` to return an `Optional<Instruction::CastOps>`, so we're not having to keep two functions in sync like this...).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92571/new/

https://reviews.llvm.org/D92571



More information about the libcxx-commits mailing list