[libcxx-commits] [PATCH] D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D92212#2431802 <https://reviews.llvm.org/D92212#2431802>, @georgthegreat wrote:

> Should not we remove ` || !defined(__cpp_char8_t)` part of LIBCPP_NO_HAS_CHAR8_T then?
> This looks like an attempt to support compilation with `-std=c++20 -fnochar8_t` which is the most weird mode ever (and it is not tested via CI)

On the contrary, the intent is that if you can't migrate to `-std=c++20` because `char8_t` is giving you trouble, then you can use `-std=c++20 -fno-char8_t` to migrate to C++20 **except for the `char8_t` part**. So this is purposefully supported, or at least that's the intent. Does that make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92212/new/

https://reviews.llvm.org/D92212