[libcxx-commits] [PATCH] D92255: [libc++] [P0202] constexpr set_union, set_difference, set_symmetric_difference, merge

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I'm fine with the current testing approach, if there's a commitment to go back and use the same tests for both constexpr and non-constexpr after the fact. There's a few algorithms that contain tests using `<random>` -- those can be split off to a separate function and run in the runtime context only.

Personally, my approach would have been to do the groundwork and make the tests constexpr friendly first, and then submit a patch to actually run them in constexpr context. If you want to proceed the other way around, I'm fine with that. But the test coverage for constexpr algorithms can't be as naive as it is in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92255/new/

https://reviews.llvm.org/D92255