[libcxx-commits] [PATCH] D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 3 09:38:38 PST 2020

ldionne abandoned this revision.
ldionne added a comment.

After speaking with Marshall offline, I am now of the opinion that we don't want to do this, in any form.

- We don't want to support `char8_t` in `-std=c++17` or older standards, ever. That's according to our policy.
- We do support `-std=c++2a -fno-char8_t`, via the check for whether the compiler supports `char8_t` (using `__cpp_char8_t`). That supports the migration story, where someone migrates to C++20 by using `-std=c++2a` but can't migrate the `char8_t` part, so they use `-std=c++2a -fno-char8_t`.

Whether we should replace `_LIBCPP_HAS_NO_CHAR8_T` by `!__cpp_lib_char8_t` is a different topic. My personal opinion is that we should, in order to remove custom macros as much as we can, but we're still talking about that.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list