[libcxx-commits] [PATCH] D91169: [14/N] [libcxx] Implement the current_path function for windows

[Adrian McCarthy via Phabricator via libcxx-commits]

amccarth added inline comments.


================
Comment at: libcxx/src/filesystem/operations.cpp:1139
+#if defined(_LIBCPP_WIN32API)
+  std::unique_ptr<wchar_t, decltype(&::free)> buff(::_wgetcwd(nullptr, 0),
+                                                   &::free);
----------------
Is `_wgetcwd` the right choice here?  Shouldn't this instead go straight to Windows with `GetCurrentDirectoryW` so it doesn't take a dependence on MSVC's CRT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91169/new/

https://reviews.llvm.org/D91169