[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review.

In D92214#2426796 <https://reviews.llvm.org/D92214#2426796>, @ldionne wrote:

> Looks okay except for the synopsis nitpick, however as you say the Apple ABI list needs to be updated. If you rebase on top of `master` and re-submit, the failing jobs should tell you what symbols you're missing (in the logs). You could add them to the Apple ABI lists (please make sure to sort :-), and the CI should pass.

@curdeius already committed the Buildkite ABI list improvements. So I copied the Apple ABI list artifact of the failed build :-) A lot easier than looking in the logs ;-)



================
Comment at: libcxx/include/format:16
+namespace std {
+  // [format.context], class template basic_format_context
+  template<class Out, class charT> class basic_format_context;
----------------
ldionne wrote:
> The synopsis should only contain the parts that we implement. Or at least it's always been my impression.
I'll update it in the next version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214