[libcxx-commits] [PATCH] D92325: Add std::hash<char8_t> specialization if char8_t is enabled

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: libcxx/test/libcxx/extensions/hash/specializations.pass.cpp:26
     assert(__gnu_cxx::hash<unsigned char>()(42) == 42);
+    #ifdef __cpp_lib_char8_t
+    assert(__gnu_cxx::hash<char8_t>()(42) == 42);
----------------
georgthegreat wrote:
> mclow.lists wrote:
> > Here too.
> I think test (due to being a library client) should continue checking the flag defined by the standard `__cpp_lib_char8_t`.
> 
> I have fixed it to check the value of the macro,
Since the test is libc++-specific (it's in the test/libcxx hierarchy, as opposed to test/std), it *could* use `_LIBCPP_NO_HAS_CHAR8_T`. However, this is fine.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92325/new/

https://reviews.llvm.org/D92325