[libcxx-commits] [PATCH] D92229: [libc++] Update clang-format configuration

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 2 01:18:53 PST 2020


curdeius added inline comments.


================
Comment at: libcxx/include/variant:1666
 
-  inline _LIBCPP_INLINE_VISIBILITY
-  result_type operator()(const argument_type&) const _NOEXCEPT {
+  inline _LIBCPP_INLINE_VISIBILITY result_type
+  operator()(const argument_type&) const _NOEXCEPT {
----------------
ldionne wrote:
> What controls this? I would *love* to move away from declaring the return type of the function above, since it gets lost in our numerous attributes.
I guess the hypothetical `AlwaysBreak*Before*ReturnType` (there is only `AlwaysBreakAfterReturnType` currently). That shouldn't be something difficult to implement in clang-format I guess.
I agree that the return type can get lost with all the attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92229/new/

https://reviews.llvm.org/D92229



More information about the libcxx-commits mailing list