[libcxx-commits] [PATCH] D92250: [libc++] Consistently replace `std::` qualification with `_VSTD::` or nothing. NFCI.

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 1 19:26:53 PST 2020


mclow.lists added inline comments.


================
Comment at: libcxx/include/memory:2086
   {
-    using std::swap;
+    using _VSTD::swap;
     swap(first(), __x.first());
----------------
This one may not be correct. 
 If a user has implemented an overload for `std::swap` for `T1` or `T2`, then it's not clear to me that this wil find it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92250/new/

https://reviews.llvm.org/D92250



More information about the libcxx-commits mailing list