[libcxx-commits] [PATCH] D91379: [libc++] Factor out common logic for calling aligned allocation

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 1 15:20:40 PST 2020


ldionne added a comment.

In D91379#2423372 <https://reviews.llvm.org/D91379#2423372>, @dmajor wrote:

> Our mingw builds are failing with `error: no member named '_aligned_malloc' in the global namespace`. Should the `new` header have an `#include <malloc.h>` somewhere?

That's weird, as we were not including `<malloc.h>` anywhere before either. Can you confirm that including `<malloc.h>` fixes your issue? I'm wary of adding non standard includes in our headers, since it causes all kinds of problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91379/new/

https://reviews.llvm.org/D91379



More information about the libcxx-commits mailing list