[libcxx-commits] [PATCH] D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 1 14:08:44 PST 2020
mstorsjo added a subscriber: ldionne.
mstorsjo added a comment.
In D91133#2426605 <https://reviews.llvm.org/D91133#2426605>, @amccarth wrote:
> These test look pretty thorough. I think these will be useful in finding portability problems.
>
> Given the TODO in the description, I'll hold off on accepting this revision.
@ldionne Where should this kind of new test be placed? It doesn't test strictly one specific method, but tests some specific aspects of both constructors and observers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91133/new/
https://reviews.llvm.org/D91133
More information about the libcxx-commits
mailing list