[libcxx-commits] [PATCH] D88818: [libc++] Add missing XFAIL to tests that need __atomic_* libcalls
Alexander Richardson via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 1 08:27:25 PST 2020
arichardson added a comment.
In D88818#2425777 <https://reviews.llvm.org/D88818#2425777>, @ldionne wrote:
> This technically regresses our coverage of atomics on Apple platforms, since those tests are testing both small and large types. I'm OK with that, but I'll make it a priority to investigate shipping support for non-lockfree atomics on Apple platforms.
With these patches the tests still run on my macOS 10.15 laptop, it's just `libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_is_lock_free.pass.cpp` that no longer runs. In some ways this is now testing more code on Apple platforms since the `TestFunctor<LargeUserAtomicType>` is no longer ifdef'd away.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits