[libcxx-commits] [PATCH] D91911: [libc++] Add a 'is-lockfree-runtime-function' lit feature

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 1 08:22:39 PST 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Apart from the TODO comment, LGTM. Ship it with the comment.



================
Comment at: libcxx/utils/libcxx/test/features.py:52
+          """)),
+  Feature(name='is-lockfree-runtime-function',
+          when=lambda cfg: sourceBuilds(cfg, """
----------------
Can you add a TODO to remove this once compiler-rt ships `atomic_is_lockfree`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91911/new/

https://reviews.llvm.org/D91911



More information about the libcxx-commits mailing list