[libcxx-commits] [PATCH] D92325: Add std::hash<char8_t> specialization if char8_t is enabled

[Yuriy Chernyshov via Phabricator via libcxx-commits]

georgthegreat added inline comments.


================
Comment at: libcxx/test/libcxx/extensions/hash/specializations.pass.cpp:26
     assert(__gnu_cxx::hash<unsigned char>()(42) == 42);
+    #ifdef __cpp_lib_char8_t
+    assert(__gnu_cxx::hash<char8_t>()(42) == 42);
----------------
mclow.lists wrote:
> Here too.
I think test (due to being a library client) should continue checking the flag defined by the standard `__cpp_lib_char8_t`.

I have fixed it to check the value of the macro,


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92325/new/

https://reviews.llvm.org/D92325