[libcxx-commits] [PATCH] D92325: Add std::hash<char8_t> specialization if char8_t is enabled
Yuriy Chernyshov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 1 02:13:50 PST 2020
georgthegreat added inline comments.
Comment at: libcxx/test/libcxx/extensions/hash/specializations.pass.cpp:26
assert(__gnu_cxx::hash<unsigned char>()(42) == 42);
+ #ifdef __cpp_lib_char8_t
+ assert(__gnu_cxx::hash<char8_t>()(42) == 42);
> Here too.
I think test (due to being a library client) should continue checking the flag defined by the standard `__cpp_lib_char8_t`.
I have fixed it to check the value of the macro,
CHANGES SINCE LAST ACTION
More information about the libcxx-commits