[libcxx-commits] [PATCH] D91292: [libc++] [P0935] [C++20] Eradicating unnecessarily explicit default constructors from the standard library.
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 1 00:08:24 PST 2020
curdeius added a comment.
@ldionne, 've discussed it with @zoecarver, and we decided that I'll take it over. It might take some time as there are many things to change (and test), but I'll appreciate your feedback.
My doubts:
- is using `make_implicit` really necessary or just `test_convertible` is enough? Using `make_implicit` tests as well that the default parameter is the correct one. It's not always possible (as in `random_device` for instance).
- name and location of `make_implicit`?
- I added as well test for ctors being explicit, and that was not tested before.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91292/new/
https://reviews.llvm.org/D91292
More information about the libcxx-commits
mailing list