[libcxx-commits] [PATCH] D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 27 11:21:00 PDT 2020


ldionne added a comment.

In D86598#2242413 <https://reviews.llvm.org/D86598#2242413>, @Nicu wrote:

> As for the fix, if I remove that `inline` it breaks the external threading mode, [...]

Actually, looking at it again, the fix is to always use `_LIBCPP_INLINE_VISIBILITY`. Please rebase your change on top of 21a1a263a6d9c0c44ef8eb0744786e2aa5d59e53


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86598/new/

https://reviews.llvm.org/D86598



More information about the libcxx-commits mailing list