[libcxx-commits] [PATCH] D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode

Thu Aug 27 07:54:29 PDT 2020

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I would like this and https://reviews.llvm.org/D86599 to be a single review, since I see those two as making the support for an external threading library official.

================
Comment at: libcxx/CMakeLists.txt:262
      This option may only be set to ON when LIBCXX_ENABLE_THREADS=ON" OFF)
+option(LIBCXX_TESTING_EXTERNAL_THREAD_API
+  "Build libc++ with an example externalized threading API provided
----------------
I would like this test to be enabled unconditionally. We should always be testing it, and I don't want to add more logic to the CMake just to enable a test for another configuration.

Also, since this is just adding a test, we should be able to do so without touching the main `CMakeLists.txt` at all. The only code changes should be under `libcxx/test`, and the test should run through Lit like the other ones. I recognize this might be more work, but stringing the test of a given configuration by hacking around libc++'s build itself is just not a sustainable direction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86704/new/

https://reviews.llvm.org/D86704