[libcxx-commits] [PATCH] D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/src/CMakeLists.txt:344
+
+  target_include_directories(cxx_external_threads PRIVATE ${LIBCXX_INCLUDE_DIR})
 endif()
----------------
I believe it would be better to use `target_link_libraries(cxx_external_threads PRIVATE cxx-headers)`. This will setup the right flags for using the current libc++ headers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86598/new/

https://reviews.llvm.org/D86598