[libcxx-commits] [PATCH] D86411: [libunwind] Remove static_assert / __has_feature macros

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added a comment.

In D86411#2233326 <https://reviews.llvm.org/D86411#2233326>, @mstorsjo wrote:

> Oh, ok, I see - maybe CMake deduced that the option wasn't needed in my case, when building with a compiler that defaults to a new enough version.

Seems plausible. Are you using MSVC or clang-cl, by any chance?

> In any case, as we seem to already rely on C++11 features extensively, this surely should be ok - so LGTM, and sorry for the unexpected breakage.

No problem. I think you couldn't have anticipated that two static_asserts would break something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86411/new/

https://reviews.llvm.org/D86411