[libcxx-commits] [PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

Mon Aug 24 09:34:16 PDT 2020

tambre added a comment.

In D86308#2233934 <https://reviews.llvm.org/D86308#2233934>, @teemperor wrote:

> In D86308#2229936 <https://reviews.llvm.org/D86308#2229936>, @tambre wrote:
>
>> In D86308#2229901 <https://reviews.llvm.org/D86308#2229901>, @teemperor wrote:
>>
>>> Sorry, just got around to check this out. With the new workaround this seems to work on macOS (the initial patch did produce the same error).
>>
>> Many thanks!
>> I've submitted an upstream CMake MR to hopefully fix this <https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5152>. I'd appreciate if you could test that too. There's an example testcase in CMake issue 20771 <https://gitlab.kitware.com/cmake/cmake/-/issues/20771>.
>
> With that CMake patch your original patch compiles just fine on macOS. Feel free to add a FIXME that this workaround can be removed when the CMake version you merged this is because the new minimum required. Thanks!

I've guarded the Apple workaround behind CMake 3.19 version check. I'll ensure that the fix on the CMake side makes it into that version.

I'll commit this tomorrow if there are no objections.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86308/new/

https://reviews.llvm.org/D86308