[libcxx-commits] [PATCH] D86411: [libunwind] Remove static_assert / __has_feature macros

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Aug 23 12:37:16 PDT 2020


mstorsjo added a comment.

I guess this fix makes sense - I'd be surprised if we don't already require C++11 for building in general.

However I do see that when building, the cmake project files don't seem to force building in C++11 mode (at least when building, I don't see any `-std=c++11` or similar), so this would break building with older versions of GCC that do support C++11 but still default to C++98, so I guess it'd be safest if we'd have something that enforces the version of C++ that actually is required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86411/new/

https://reviews.llvm.org/D86411



More information about the libcxx-commits mailing list