[libcxx-commits] [PATCH] D75954: Cache uwnind frame headers as they are found.

Tue Aug 18 01:30:22 PDT 2020

hans added a comment.

In D75954#2220392 <https://reviews.llvm.org/D75954#2220392>, @saugustine wrote:

> In D75954#2219870 <https://reviews.llvm.org/D75954#2219870>, @dim wrote:
>
>> It looks like the need for some locking in this `FrameHeaderCache` was completely overlooked? Or at least, having a cache per thread would make locking unnecessary, but it would cost more memory.
>
> Well, not _completely_ overlooked. Looks like glibc locks things and other libc's don't. Should be easy to add a lock here for non glibc targets.

Sterling, do you think this will be fixed soon so we can get it in the llvm 11 release?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75954/new/

https://reviews.llvm.org/D75954