[libcxx-commits] [PATCH] D85466: [libcxx] Add C++20 source_location header

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 6 13:05:17 PDT 2020


mclow.lists added a comment.

A couple of quick comments, more to come.



================
Comment at: libcxx/test/libcxx/support/source_location.pass.cpp:8
+//===----------------------------------------------------------------------===//
+//
+
----------------
This test needs an XFAIL for pre-c++20 tests


================
Comment at: libcxx/test/libcxx/support/source_location.pass.cpp:10
+
+// <source_location>
+
----------------
tests that are not libc++ specific go into `test/std`, not `test/libcxx`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85466/new/

https://reviews.llvm.org/D85466



More information about the libcxx-commits mailing list