[libcxx-commits] [PATCH] D82627: Fix CFI issues in <future>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I like this a lot better. It's also more explicit on the intent since it uses `_LIBCPP_NO_CFI`. A few changes requested, but generally OK.

Note that I'll be on vacation for a week starting tomorrow. If you make the changes I ask above, please feel free to commit this.



================
Comment at: libcxx/include/future:1827
+
+    _LIBCPP_NO_CFI __base* buf_() { return (__base*)&__buf_; }
+
----------------
This would need to be mangled as `__buf()`. I'd suggest `__get_buf()` or whatever you prefer.

Also, please use `_LIBCPP_INLINE_VISIBILITY`.


================
Comment at: libcxx/include/future:1936
+        __f.__f_->__move_to(buf_());
         __f_ = (__base*)&__buf_;
     }
----------------
Would it make sense to say `__f_ = this->__get_buf()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82627/new/

https://reviews.llvm.org/D82627