[libcxx-commits] [PATCH] D85051: Improve the representation of <compare>'s zero-only type.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.fail.cpp:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
Can you name this file `zero_type.verify.cpp` instead?


================
Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.fail.cpp:19
+
+#define TEST_OP(op)                                                            \
+  void(v op 0L);                                                               \
----------------
You could take both `op` and `v` here to avoid `v` coming from "nowhere".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85051/new/

https://reviews.llvm.org/D85051