[libcxx-commits] [libcxx] 5d46e4b - [libc++] Don't over-quote arguments to DSL tests

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-04-30T14:23:24-04:00
New Revision: 5d46e4b0daef0f29b6fb4ae7280d7a98e6422ec8

URL: https://github.com/llvm/llvm-project/commit/5d46e4b0daef0f29b6fb4ae7280d7a98e6422ec8
DIFF: https://github.com/llvm/llvm-project/commit/5d46e4b0daef0f29b6fb4ae7280d7a98e6422ec8.diff

LOG: [libc++] Don't over-quote arguments to DSL tests

On Windows, quoting with single-quotes is both unnecessary and incorrect.
If the arguments are properly handled by Lit (which they are), quoting
should not be necessary.

Added: 
    

Modified: 
    libcxx/test/libcxx/selftest/dsl/dsl.sh.py

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/selftest/dsl/dsl.sh.py b/libcxx/test/libcxx/selftest/dsl/dsl.sh.py
index 56507851fd16..2f0e73715194 100644
--- a/libcxx/test/libcxx/selftest/dsl/dsl.sh.py
+++ b/libcxx/test/libcxx/selftest/dsl/dsl.sh.py
@@ -9,11 +9,11 @@
 # TODO: Unbreak this on Windows
 # UNSUPPORTED: host-windows
 
-# RUN: %{python} '%s' '%S' '%T' '%{escaped_exec}' \
-# RUN:                          '%{escaped_cxx}' \
-# RUN:                          '%{escaped_flags}' \
-# RUN:                          '%{escaped_compile_flags}' \
-# RUN:                          '%{escaped_link_flags}'
+# RUN: %{python} %s %S %T %{escaped_exec} \
+# RUN:                    %{escaped_cxx} \
+# RUN:                    %{escaped_flags} \
+# RUN:                    %{escaped_compile_flags} \
+# RUN:                    %{escaped_link_flags}
 # END.
 
 import base64
@@ -36,8 +36,8 @@
 
 # Steal some parameters from the config running this test so that we can
 # bootstrap our own TestingConfig.
-SOURCE_ROOT, EXEC_PATH, EXEC, CXX, FLAGS, COMPILE_FLAGS, LINK_FLAGS = sys.argv[1:]
-sys.argv = sys.argv[:1]
+SOURCE_ROOT, EXEC_PATH, EXEC, CXX, FLAGS, COMPILE_FLAGS, LINK_FLAGS = sys.argv[1:8]
+sys.argv[1:8] = []
 
 class SetupConfigs(unittest.TestCase):
     """