[libcxx-commits] [PATCH] D78816: Fix ostream for complex numbers with fixed field width

Duncan P. N. Exon Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 30 10:41:09 PDT 2020


dexonsmith added a comment.

@cantonios, thanks for working on this.  I'll let @ldionne or others review in detail, but I have two high-level notes:

- Given that this is a partial revert of c3478eff7a65d6a77b34e756eabc7176a2b422e8 <https://reviews.llvm.org/rGc3478eff7a65d6a77b34e756eabc7176a2b422e8> (reviewed at https://reviews.llvm.org/D71214) I think the commit message should mention that commit.
- To avoid the same issue in the future, I think this needs a test!  Probably somewhere in `libcxx/test/std/numerics/complex.number` makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78816/new/

https://reviews.llvm.org/D78816





More information about the libcxx-commits mailing list