[libcxx-commits] [PATCH] D74813: [RFC] Add hash of block contents to function block names

Duncan P. N. Exon Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 29 16:13:00 PDT 2020


dexonsmith added a comment.

In D74813#2011083 <https://reviews.llvm.org/D74813#2011083>, @alexbdv wrote:

> @dexonsmith what regression are you referring to ? 
>  What this change is effectively doing now is changing the numbering of the blocks from incremental to hash-based.
>  So the demangler functionality remains the same (i think) - I saw that it is ignoring the (currently incrememntal) number, so changing it shouldn't make a difference.
>  Did I miss anything ?


I think you missed @erik.pilkington's comment, which I was replying to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74813/new/

https://reviews.llvm.org/D74813





More information about the libcxx-commits mailing list