[libcxx-commits] [PATCH] D78245: [LIT] Make `%T` unique for every test

[Paul Robinson via Phabricator via libcxx-commits]

probinson added a comment.

D35396 <https://reviews.llvm.org/D35396> is pretty long, so as a public service, summarizing the objections to %T from D35396 <https://reviews.llvm.org/D35396>, having lit always pre-create a %T directory would slow down test runs.  Considering %T has been deprecated and work done to remove it from llvm, clang, etc, there are not many tests that use it and it would pretty much be an unnecessary penalty for everyone (except libcxx, who needs to create the directory anyway).  (I think I got that right.)

If lit would do this directory pre-creation only if it actually saw %T in the test, that I think would answer the objection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78245/new/

https://reviews.llvm.org/D78245