[libcxx-commits] [libcxx] 5e37cf0 - [libc++] Try re-enabling long-disabled locale tests on Apple platforms
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Apr 29 09:03:16 PDT 2020
Author: Louis Dionne
Date: 2020-04-29T12:03:05-04:00
New Revision: 5e37cf0adc57fe91423dd56c88adb26ac35ef45e
URL: https://github.com/llvm/llvm-project/commit/5e37cf0adc57fe91423dd56c88adb26ac35ef45e
DIFF: https://github.com/llvm/llvm-project/commit/5e37cf0adc57fe91423dd56c88adb26ac35ef45e.diff
LOG: [libc++] Try re-enabling long-disabled locale tests on Apple platforms
These two locale tests are disabled because they were said to "pass in
an uncontrolled manner on Apple platforms". This commit re-enables them
to see what that means, and whether that is still relevant on the
platforms we test.
Before this commit, the tests were either XFAILed or UNSUPPORTED on
Apple and Linux, which is pretty much all the systems we support. If
the tests truly don't work anywhere, they should be removed instead.
Added:
Modified:
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
Removed:
################################################################################
diff --git a/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp b/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
index 74bc7ba1ef37..f9b52aa89b09 100644
--- a/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
@@ -5,10 +5,7 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
-//
-// This test is passing in an uncontrolled manner in some Apple environment.
-// UNSUPPORTED: darwin
-//
+
// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd
diff --git a/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp b/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
index 3bf9c4ec0cd9..c2b5840c849b 100644
--- a/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
@@ -5,10 +5,7 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
-//
-// This test is passing in an uncontrolled manner in some Apple environment.
-// UNSUPPORTED: darwin
-//
+
// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd
More information about the libcxx-commits
mailing list