[libcxx-commits] [libcxx] 05ef484 - [libc++] Properly handle --no-execute in the new format

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 27 10:37:49 PDT 2020


Author: Louis Dionne
Date: 2020-04-27T13:37:39-04:00
New Revision: 05ef484df5678bcf531ed18700df2e521d38802a

URL: https://github.com/llvm/llvm-project/commit/05ef484df5678bcf531ed18700df2e521d38802a
DIFF: https://github.com/llvm/llvm-project/commit/05ef484df5678bcf531ed18700df2e521d38802a.diff

LOG: [libc++] Properly handle --no-execute in the new format

If --no-execute is passed, we shouldn't report XFAIL tests as passing,
or they will be considered to XPASS.

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/newformat.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/newformat.py b/libcxx/utils/libcxx/test/newformat.py
index 2ee6e502da6d..8c402bfebc37 100644
--- a/libcxx/utils/libcxx/test/newformat.py
+++ b/libcxx/utils/libcxx/test/newformat.py
@@ -333,7 +333,7 @@ def _executeShTest(self, test, litConfig, steps, fileDependencies=None):
             return script
 
         if litConfig.noExecute:
-            return lit.Test.Result(lit.Test.PASS)
+            return lit.Test.Result(lit.Test.XFAIL if test.isExpectedToFail() else lit.Test.PASS)
         else:
             _, tmpBase = lit.TestRunner.getTempPaths(test)
             useExternalSh = True


        


More information about the libcxx-commits mailing list