[libcxx-commits] [libcxx] 4fd92cc - [libc++] Get rid of pipe in command to check whether verify is supported

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 24 12:30:37 PDT 2020


Author: Louis Dionne
Date: 2020-04-24T15:30:25-04:00
New Revision: 4fd92cc475567f2001344d7049fe7ac592e8bdbe

URL: https://github.com/llvm/llvm-project/commit/4fd92cc475567f2001344d7049fe7ac592e8bdbe
DIFF: https://github.com/llvm/llvm-project/commit/4fd92cc475567f2001344d7049fe7ac592e8bdbe.diff

LOG: [libc++] Get rid of pipe in command to check whether verify is supported

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/newformat.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/newformat.py b/libcxx/utils/libcxx/test/newformat.py
index a494fb0fbae1..ed5da6184fdd 100644
--- a/libcxx/utils/libcxx/test/newformat.py
+++ b/libcxx/utils/libcxx/test/newformat.py
@@ -149,7 +149,7 @@ def _checkBaseSubstitutions(self, substitutions):
 
     # Determine whether clang-verify is supported.
     def _supportsVerify(self, test):
-        command = "echo | %{cxx} -xc++ - -Werror -fsyntax-only -Xclang -verify-ignore-unexpected"
+        command = "%{{cxx}} -xc++ {} -Werror -fsyntax-only -Xclang -verify-ignore-unexpected".format(os.devnull)
         command = lit.TestRunner.applySubstitutions([command], test.config.substitutions,
                                                     recursion_limit=test.config.recursiveExpansionLimit)[0]
         devNull = open(os.devnull, 'w')


        


More information about the libcxx-commits mailing list