[libcxx-commits] [PATCH] D71214: [libc++] reduce <complex> parsing time

[Nikita Kniazev via Phabricator via libcxx-commits]

nick marked an inline comment as done.
nick added inline comments.


================
Comment at: libcxx/include/complex:1444
 {
-    basic_ostringstream<_CharT, _Traits> __s;
-    __s.flags(__os.flags());
----------------
cantonios wrote:
> nick wrote:
> > ldionne wrote:
> > > I'm thinking there must be a reason why it was written that way, but I can't think of any and your version indeed seems more straightforward.
> > I tried to dig into history and the code is from initial commit, so I hoped I will get insights during the review.
> It was written this way to respect properties like field width.  This now breaks fixed-width printing of complex numbers.
> 
> See https://reviews.llvm.org/D78816
Right, @ldionne could you please revert the commit as I do not have a fix for that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71214/new/

https://reviews.llvm.org/D71214