[libcxx-commits] [PATCH] D74813: [RFC] Add hash of block contents to function block names

[James Henderson via Phabricator via libcxx-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-cxxfilt/invalid.test:1
-RUN: llvm-cxxfilt -n _Z1fi __Z1fi f ___ZSt1ff_block_invoke | FileCheck %s
+RUN: llvm-cxxfilt -n _Z1fi __Z1fi f ___ZSt1ff_block_invoke ___Z7my_mainv_block_invoke_ZTSi_ZTSj_ZTSPVK3sss | FileCheck %s
 
----------------
I'm not sure this test needs updating with an additional case?

This test is just to show what llvm-cxxfilt prints when an input is not a valid mangled name (I think). I think the existing block_invoke example is there merely to show triple underscores can be handled, but I actually am doubtful that it really belongs here, as that sounds more like belonging in the demangler testing.

NB. I haven't actually looked at the history of this test or the source code to verify anything I just said.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74813/new/

https://reviews.llvm.org/D74813