[libcxx-commits] [PATCH] D78330: [libc++abi] Add a rate limiter when logging dynamic_cast errors

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 22 07:33:43 PDT 2020


ldionne added a comment.

In D78330#1995574 <https://reviews.llvm.org/D78330#1995574>, @jfb wrote:

> You probably want to assert that `std::atomic<size_t>::is_always_lock_free` so weird platforms don't suddenly require a lock, or the lock shard.


I agree, but we build libcxxabi as C++11, not C++17 :-(. As soon as we upgrade our CMake, I'll change libcxx and libcxxabi to build as C++17 and I'll fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78330/new/

https://reviews.llvm.org/D78330





More information about the libcxx-commits mailing list