[libcxx-commits] [PATCH] D78427: [libcxx] Add c++20 <numbers>

kamlesh kumar via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 21 17:54:46 PDT 2020


kamleshbhalui marked an inline comment as done.
kamleshbhalui added inline comments.


================
Comment at: libcxx/include/numbers:84
+constexpr T _AlwaysFalse() {
+   static_assert(value<T>, "Require Floating Point types");
+   return T();
----------------
zoecarver wrote:
> Why not `static_assert(false)`? Wouldn't that be more clear? 
in that case static_assert will fail even when this template is not instantiated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78427/new/

https://reviews.llvm.org/D78427





More information about the libcxx-commits mailing list