[libcxx-commits] [PATCH] D78370: [libc++/abi/unwind] Rename Lit features for no exceptions to -fno-exceptions

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 20 02:06:49 PDT 2020


ldionne added a comment.

In D78370#1989936 <https://reviews.llvm.org/D78370#1989936>, @dexonsmith wrote:

> `no-exceptions` sounds a bit better to me as a feature name rather than the Clang command-line argument, although what you have is probably okay too.  (Unifying sounds great!  I'll let someone else sign off though.)


We use `-fmeow` for other Lit features in libc++ pretty widely (e.g. `-fmodules`). I agree with you though, and I was planning on changing the names of many features once I'm done with the changes started in https://reviews.llvm.org/D78381.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78370/new/

https://reviews.llvm.org/D78370





More information about the libcxx-commits mailing list