[libcxx-commits] [PATCH] D77786: [AArch64] Add v8.5 Branch Target Identification support.

Momchil Velikov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 15 01:36:07 PDT 2020


chill added inline comments.


================
Comment at: libunwind/src/assembly.h:162
   SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR                                  \
-  PPC64_OPD1                                                                   \
+  ARCH_OPD1                                                                    \
   SYMBOL_NAME(name):                                                           \
----------------
All right, of these are to stay named `PPC64_OPD`, then just add a new line with, say, `AARCH64_BTI`, e..g

    #define DEFINE_LIBUNWIND_FUNCTION(name)                                        \
    .globl SYMBOL_NAME(name) SEPARATOR                                           \
    HIDDEN_SYMBOL(SYMBOL_NAME(name)) SEPARATOR                                   \
    SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR                                  \
    PPC64_OPD1                                                                    \ 
    SYMBOL_NAME(name):                                                           \
    PPC64_OPD2                                                                   \
    AARCH64_BTI




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77786/new/

https://reviews.llvm.org/D77786





More information about the libcxx-commits mailing list