[libcxx-commits] [PATCH] D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with a minor comment.



================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:4229
+#if defined(__powerpc__) || defined(__s390__)
+    return getDerived().template parseFloatingLiteral<double>();
+#else
----------------
Suggestion for a comment:
Handle cases where `long double`s encoded with `e` have the same size and representation as `double`s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74163/new/

https://reviews.llvm.org/D74163