[libcxx-commits] [PATCH] D74292: [libcxx] adds [concept.derived]

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked 2 inline comments as done.
cjdb added inline comments.


================
Comment at: libcxx/test/std/concepts/lang/derived_from.pass.cpp:43
+
+      static_assert(!std::derived_from<From*, To&&>);
+      static_assert(!std::derived_from<From*, const To&&>);
----------------
cjdb wrote:
> I'm not sure if the rvalue-reference checks are necessary, or if `static_assert(!std::derived_from<From*, To>)` covers this.
> CC @CaseyCarter 
Yes, they are, and that's the point of this check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74292/new/

https://reviews.llvm.org/D74292