[libcxx-commits] [PATCH] D74291: [libcxx] Adds [concept.same]

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM.

I have some concerns with how we harden our concepts,
but these can be addressed in follow up commits.



================
Comment at: libcxx/include/concepts:137
+
+#include <__config>
+#include <type_traits>
----------------
I think `__version` should be included here too.


================
Comment at: libcxx/include/concepts:161
+
+_LIBCPP_END_NAMESPACE_STD
+
----------------
I think we're missing a `_LIBCPP_POP_MACROS`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74291/new/

https://reviews.llvm.org/D74291