[libcxx-commits] [PATCH] D77296: [libc++abi] Make libunwind static linking possible in standalone builds

Tue Apr 7 07:34:49 PDT 2020

tambre added inline comments.

================
Comment at: libcxxabi/src/CMakeLists.txt:263
   if(LIBCXXABI_USE_LLVM_UNWINDER AND LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_STATIC_LIBRARY)
+    if(LIBCXXABI_UNWIND_LIBRARY_PATH)
+      set(MERGE_ARCHIVES_SEARCH_PATHS "-L${LIBCXXABI_UNWIND_LIBRARY_PATH}")
----------------
ldionne wrote:
> Where is `LIBCXXABI_UNWIND_LIBRARY_PATH` defined? I can't find that CMake option anywhere.
This is for the user to define if they want to. Same way as `LIBCXX_CXX_ABI_LIBRARY_PATH`. I've added a cache variable for this in the main file to make it easier to discover.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77296/new/

https://reviews.llvm.org/D77296