[libcxx-commits] [libcxxabi] 2eb8864 - [libc++abi] Enable the new libc++ testing format by default

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 7 06:20:40 PDT 2020


Author: Louis Dionne
Date: 2020-04-07T09:16:06-04:00
New Revision: 2eb8864be282ab89dd4ed956a7e40503f7b28e84

URL: https://github.com/llvm/llvm-project/commit/2eb8864be282ab89dd4ed956a7e40503f7b28e84
DIFF: https://github.com/llvm/llvm-project/commit/2eb8864be282ab89dd4ed956a7e40503f7b28e84.diff

LOG: [libc++abi] Enable the new libc++ testing format by default

The new format should be equivalent to the old format, and it is now the
default format when running the libc++ tests. This commit changes the
libc++abi tests to use the new format by default too. If unexpected failures
are discovered, it should be fine to revert this commit until they are
addressed.

Also note that it is still possible to use the old format by passing
`--param=use_old_format=True` when running Lit for the time being.

Added: 
    

Modified: 
    libcxxabi/test/lit.cfg

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/lit.cfg b/libcxxabi/test/lit.cfg
index d9caab7b8258..4c4aa3b2dd58 100644
--- a/libcxxabi/test/lit.cfg
+++ b/libcxxabi/test/lit.cfg
@@ -70,9 +70,10 @@ config_module = __import__(config_module_name, fromlist=['Configuration'])
 configuration = config_module.Configuration(lit_config, config)
 configuration.configure()
 configuration.print_config_info()
-if lit_config.params.get('use_new_format', False):
-    lit_config.note("Using the experimental libc++ testing format")
+if lit_config.params.get('use_old_format', False):
+    lit_config.note("Using the old libc++ testing format")
+    config.test_format = configuration.get_test_format()
+else:
+    lit_config.note("Using the new libc++ testing format")
     import libcxx.test.newformat
     config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()
-else:
-    config.test_format = configuration.get_test_format()


        


More information about the libcxx-commits mailing list