[libcxx-commits] [PATCH] D77505: [libc++] Implement <numbers>

[Raul Tambre via Phabricator via libcxx-commits]

tambre added a comment.

In D77505#1965306 <https://reviews.llvm.org/D77505#1965306>, @rsmith wrote:

> Should we have some kind of test coverage that the values of these constants are correct?


How would we test constants?

Regarding tests, as I mentioned in my comment <https://reviews.llvm.org/D77505#1962589>, I couldn't figure out how to run libc++ tests locally, so I wrote them blindly. Maybe I missed something, I'll try again tonight.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77505/new/

https://reviews.llvm.org/D77505