[libcxx-commits] [PATCH] D76171: Upstream Bionic definitions of ctype_base/regex.

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 6 13:37:57 PDT 2020


danalbert marked 4 inline comments as done.
danalbert added inline comments.


================
Comment at: libcxx/include/__locale:502
+    // historical value of the constant is preserved for ABI compatibility.
+    static const mask __regex_word = 0x8000;
+#else
----------------
ldionne wrote:
> At first I wasn't so warm on this change cause of the added complexity, and then I looked at the context around it and I screamed. It's already a mess of platform-specific choices, so I can't reasonably push back on this.
Yeah. I'd originally not upstreamed this because it's gross :(


================
Comment at: libcxx/include/regex:997
 template <class _CharT>
 struct _LIBCPP_TEMPLATE_VIS regex_traits
 {
----------------
ldionne wrote:
> Do we specialize this class anywhere?
Doesn't look like it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76171/new/

https://reviews.llvm.org/D76171





More information about the libcxx-commits mailing list