[libcxx-commits] [PATCH] D77563: [libc++] Move C++17 check around optional only in ObjC is_scalar test.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/libcxx/type_traits/is_scalar.objc.pass.mm:43
+    // underlying motivation for making blocks satisfy std::is_scalar.
     std::optional<Foo (^)(Arg<0>)> opt; (void)opt;
+#endif // C++17
----------------
You can actually remove this altogether, since I had added `libcxx/test/libcxx/utilities/optional/block.objc.pass.mm` at the time anyway. You should also rebase the patch on top of `master`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77563/new/

https://reviews.llvm.org/D77563