[libcxx-commits] [PATCH] D77500: [libc++] [ssh] Fix tarring test dependencies on Windows

Mon Apr 6 07:00:07 PDT 2020

ldionne added a comment.

After offline discussion with @broadwaylamb, we went ahead with b00a874b7c7371 <https://reviews.llvm.org/rGb00a874b7c737119c82cc3826fd3a74a9e5405e3> instead. The main difference is that b00a874b7c7371 <https://reviews.llvm.org/rGb00a874b7c737119c82cc3826fd3a74a9e5405e3> makes sure to close the `NamedTemporaryFile` before it tries to scp it, which is more in-line with the Python documentation:

> Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77500/new/

https://reviews.llvm.org/D77500