[libcxx-commits] [PATCH] D77497: [libc++] Capture the current environment in the new test format

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/libcxx/test/newformat.py:243
 
+        test.config.environment = dict(os.environ)
+
----------------
Yup, so I've been having to add the same workaround locally in some cases for ssh-agent environment variables to be picked up. However, I'm not certain this is the right place to set that, I think it should be in `config.py` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77497/new/

https://reviews.llvm.org/D77497