[libcxx-commits] [PATCH] D77359: [libunwind] --draft-- add hexagon support

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libunwind/src/AddressSpace.hpp:310
 
+  if (encoding == DW_EH_PE_omit)
+    return reinterpret_cast<pint_t>(nullptr);
----------------
I'm not familiar with this aspect of dwarf - but this seems to be a change that isn't within arch specific ifdefs, contrary to the rest of the patch. I'd like an explicit clarification of that aspect (in e.g. the commit message/description).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77359/new/

https://reviews.llvm.org/D77359