[libcxx-commits] [PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D77370#1960502 <https://reviews.llvm.org/D77370#1960502>, @compnerd wrote:

> @ldionne yeah, thats why I would prefer that we just do the following in the top level `CMakeLists.txt` for libunwind:
>
>   set(CMAKE_POSITION_INDEPENDENT_CODE YES CACHE BOOL "")
>
>
> The user can then specify this on the commandline to override the default behaviour.


Setting that globally is definitely the wrong way to go. I would actually advocate for having no setting at all and then setting `CMAKE_POSITION_INDEPENDENT_CODE` to whatever you want in your own CMake cache, but we should never hardcode something in the `CMakeLists.txt`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77370/new/

https://reviews.llvm.org/D77370